This repository was archived by the owner on Apr 26, 2019. It is now read-only.
Fix schema dump for postgres#13
Open
Fryie wants to merge 3 commits intohowaboutwe:masterfrom
Fryie:fix_schema_dump_for_postgres
Open
Fix schema dump for postgres#13Fryie wants to merge 3 commits intohowaboutwe:masterfrom Fryie:fix_schema_dump_for_postgres
Fryie wants to merge 3 commits intohowaboutwe:masterfrom
Fryie:fix_schema_dump_for_postgres
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble getting enum_tables to work with postgres. Specifically, the schema dumping would not work correctly.
I tracked the bug down to the use of the ActiveRecord "execute" method. As far as I know, that method is not portable across databases, since different database adapters may return the results in different formats.
Using #select_rows and #select_values should fix this. I have tested that this works (at least in my case) with both MySQL and Postgres.