Skip to content

Conversation

@Maxime2
Copy link

@Maxime2 Maxime2 commented May 21, 2016

  1. we do not need to use process wait as process communicate waits until process termination and the last process in the pipeline do not finish until all processes before it in the pipeline terminate, plus process wait may deadlock on pipes with huge output, see notice at https://docs.python.org/2/library/subprocess.html
  2. On Ubuntu 16.04 grep has started to give "Binary file (standard input) matches" notice into the pipe which breaks parsing.

This pull request fixes both issues making it working again on Ububtu 16.04 with our project.

Maxime2 added 2 commits May 21, 2016 21:39
… termination and the last process int the pipeline do not terminate until all previous processes int the pipeline terminate; in addition process wait may deadlock on big output
@anthrax-0
Copy link

Is it possible to upvote PR? We have the same problem on older repositories and with non-ascii usernames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants