Make OWFS hub searching more robust #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am running on Ubuntu 16.04 with recent updates and OWFS 3.1.
OWFS is reporting the 1-wire sensor filename existing on all channels when OXC conducted its search. The perl test using "-e" is always successful at line 565 in oxc.pl. When OXC tries to read the temp sensor from the wrong channel then it fails. This is the same behaviour as experienced on the command line.
This commit makes the search more robust. It checks whether the sensor is listed in the OWFS directory, rather than asking OWFS if the sensor filename exists.