Skip to content

Added a delegate protocol for user's finishing of interaction #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romanfrozzt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a delegate protocol for user's finishing of interaction #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions HCSStarRatingView/HCSStarRatingView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

typedef BOOL(^HCSStarRatingViewShouldBeginGestureRecognizerBlock)(UIGestureRecognizer *gestureRecognizer);

@protocol HCSStarRatingViewDelegate;

IB_DESIGNABLE
@interface HCSStarRatingView : UIControl
@property (nonatomic) IBInspectable NSUInteger maximumValue;
Expand All @@ -42,5 +44,13 @@ IB_DESIGNABLE
@property (nonatomic, strong) IBInspectable UIImage *emptyStarImage;
@property (nonatomic, strong) IBInspectable UIImage *halfStarImage;
@property (nonatomic, strong) IBInspectable UIImage *filledStarImage;

@property (nonatomic, weak) IBOutlet id<HCSStarRatingViewDelegate> delegate;
Copy link
Owner

@hsousa hsousa Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you made this an outlet! ❤️

@end

@protocol HCSStarRatingViewDelegate <NSObject>

@optional
- (void)userFinishedRatingOnView:(HCSStarRatingView*)ratingView withRating:(CGFloat)value;
Copy link
Owner

@hsousa hsousa Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to something like - (void)ratingView:(HCSStarRatingView *)ratingView userFinishedRatingWithValue:(CGFloat)value;

Makes more sense to me as a delegate API.

Copy link
Author

@romanfrozzt romanfrozzt Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I also think it's kinda clunky at the moment.

Copy link
Owner

@hsousa hsousa Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, in that case I'll merge the PR and update the pod once this is changed. Thanks! 😄

Copy link
Owner

@hsousa hsousa Nov 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this could just be - (void)ratingViewFinishedRating:(HCSStarRatingView *)ratingView, since whoever's implementing can get the value from ratingView.


@end
6 changes: 6 additions & 0 deletions HCSStarRatingView/HCSStarRatingView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,12 @@ - (void)_handleTouch:(UITouch *)touch {
[self setValue:value sendValueChangedAction:_continuous];
}

-(void)touchesEnded:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event {
if ([self.delegate respondsToSelector:@selector(userFinishedRatingOnView:withRating:)]) {
[self.delegate userFinishedRatingOnView:self withRating:self.value];
}
}

#pragma mark - First responder

- (BOOL)canBecomeFirstResponder {
Expand Down