Support for relative urls #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2017 14:10
Added url rewriting to support linking to html files relative to .md documentation in the same repository of a specific revision.
|
Some users disable the HTTP Referer header because of privacy concerns. For those users this trick would result in broken links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I love your work on htmlpreview. Great stuff.
I was struggling with links from markdown repositories to html files in the same repository, as I did not find a way to make them relative to the revision.
So in this pull request I added url rewriting to support linking to html files relative to .md
documentation in the same repository of a specific revision.
There is one implication that htmlpreview.github.io will need to be hosted on https, but using caddy that should not be a problem.