Merge new changes from light theme #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Ubuntu Budgie icon, from Andreas Bondi aka "pencap" on github
This repo is an independent fork now, adjusting install instructions and add notification of this status on top.
in this thread https://github.com/munlik/refind-theme-regular/issues/8#issuecomment-406380182 added 512-192 size of icons in the main icons folder added a helper script to copy over images once you're done and updated readmen to tell how it's used added commented out options in theme.conf to show possible values at a glance
…from d4k0 as my edit to the other ones wasn't actually as good as I thought it was. It seems the script's DPI settings (passed to inkscape to do batch-exporting) in render-bitmap.sh are wrong. It seems that with the current value (DPI=90, the old inkscape's default DPI) screws up exporting, and the exported small png image is 45x45, NOT 48x48 as it should be. Bigger icons also suffer from similar scaling issues (eg 120x120 instead of 128x128), but being bigger it's less noticeable. Changing that to DPI=96, the current inkscape default dpi, fixes the issue and the png are created at the right sizes, and shown correctly in my tests. fixed the theme.conf settings (forgot to comment out options that should have been left commented I assume that this happens because Inkscape changed since the time the theme (and scripts) were written originally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already made the new small icons white