Implement tests to expose sequencing bugs #180
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diggsey
force-pushed
the
failing-tests
branch
from
9b19b8f to
c82390b
Compare
|
@yoshuawuyts did you have a chance to review these test cases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the addition of a
sleeptoaccept_one:This is used by the
test_accept_partial_read_sequential_requeststest to make it easier to reproduce the problem. Hopefully you agree that such a delay could naturally occur in a complex program given the surrounding async operations, and that if introducing a delay here causes a problem, then the code already had a bug. If not, then ignore that test.Identical tests have been added to #179 to show that it fixes these issues.