Add MambaSSM as a library #802
Conversation
Wauplin
requested review from
SBrandeis,
gary149,
julien-c,
osanseviero and
pcuenca
as code owners
osanseviero
left a comment
osanseviero
left a comment
There was a problem hiding this comment.
LGTM if naming is agreed
| repoName: "mindspore", | ||
| repoUrl: "https://github.com/mindspore-ai/mindspore", | ||
| }, | ||
| mamba_ssm: { |
There was a problem hiding this comment.
just mamba would be cleaner, branding-wise?
| mamba_ssm: { | |
| mamba: { |
There was a problem hiding this comment.
and it's pip install mamba-ssm on PyPI so maybe a better option too
I think i'd go with mamba personally
There was a problem hiding this comment.
We discussed this with @osanseviero. The problem of simply mamba is that it's a transformers architecture as well so it might create some conflicts. Also having mamba_ssm as library_name and mamba as tag helps with code snippets (to import Mamba class).
There was a problem hiding this comment.
We could have Mamba as prettyName but it might be misleading
There was a problem hiding this comment.
ok but then dash rather than underscore no?
There was a problem hiding this comment.
nvm let's not complicate stuff, LGTM as is :)
There was a problem hiding this comment.
good point, addressed in e3e7e62 and state-spaces/mamba@961eccb
|
@osanseviero @julien-c I've updated the code snippet. In the end only |
|
(I would have waited for state-spaces/mamba#471 to be merged but no big deal) |
This PR adds https://github.com/state-spaces/mamba as an official library on the Hub.
Let's wait for Mamba integration to be merged (coming soon) + having a few first models uploaded on the Hub.
cc @osanseviero @NielsRogge @tridao
Related PR on Mamba side: state-spaces/mamba#471