Fix: update _run_script to use individual language per script execution.#682
Open
kevtimova wants to merge 1 commit intohuggingface:mainfrom
Open
Fix: update _run_script to use individual language per script execution.#682kevtimova wants to merge 1 commit intohuggingface:mainfrom
kevtimova wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
_run_scriptmethod where script executions were always returning 0 reward due to incorrect language parameter handling.Changes:
_run_scriptmethod signature to acceptlanguage: strinstead oflanguages: List[str]Motivation: The current implementation was incorrectly passing a list of languages to individual script executions, which caused all executions to return 0 reward instead of the expected evaluation scores.