Fix Hub API URL construction #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DePasqualeOrg
force-pushed
the
fix-hub-api-url-construction
branch
from
fde6255 to
3f6ec25
Compare
DePasqualeOrg
force-pushed
the
fix-hub-api-url-construction
branch
2 times, most recently
from
76d1387 to
10209d9
Compare
DePasqualeOrg
force-pushed
the
fix-hub-api-url-construction
branch
from
10209d9 to
96333f1
Compare
mattt
approved these changes
Dec 2, 2025
Collaborator
mattt
left a comment
mattt
left a comment
There was a problem hiding this comment.
This is a good set of changes. Thanks for opening this PR, @DePasqualeOrg 🫶
pcuenca
approved these changes
Dec 4, 2025
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Makes sense, thanks a lot @DePasqualeOrg, and sorry for the oversight with pr/1!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's safer to use
appending(path:)orappending(component:)instead of string interpolation to construct URLs. The latter properly encodes the slash in revisions likepr/1, which would otherwise result in a 404 error.Before:
pr/1→ two path segments → 404After:
pr/1→pr%2F1→ worksI've also replaced the use of the deprecated
appendingPathComponentin the same file withappending(path:).