Feature/fix manifest error#71
Open
jodybitbrew wants to merge 168 commits intohuit:masterfrom
BitBrew:feature/fixManifestError
Open
Feature/fix manifest error#71jodybitbrew wants to merge 168 commits intohuit:masterfrom BitBrew:feature/fixManifestError
jodybitbrew wants to merge 168 commits intohuit:masterfrom
BitBrew:feature/fixManifestError
Conversation
added 30 commits
November 4, 2016 12:18
|
I think there are to much kind-of-hardcoded params like $profile::freeipa::public_dns. These will not work if one isn't using the role/profile pattern. There are some good efforts like adoption of hiera. But the commit history needs a cleanup (stashing and adding comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.