Skip to content

Conversation

@LordZardeck
Copy link

@LordZardeck LordZardeck commented Jan 14, 2022

This would solve #5

After looking into the code more i realized that technically you can achieve the same result through the eachPage parameter, but I feel this is a cleaner use

This also adds the ability to know where in the query we are by returning a tuple of the page items, and the current page, and total. Ideally, we might just return the meta itself so we can have an exact understanding of how many items we are getting in total, not just the pages

@mrmattrc
Copy link
Collaborator

Conceptually, I really like the idea. I feel like it would make it feel and perform significantly faster. I'd want to make sure to test it thoroughly first (which I'm sure you've already done some, @LordZardeck), but I'm all for merging it if it doesn't create any new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants