feat: EventRenamer handle event=None #777
Draft
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let
EventRenamerdefaults toNonein caseeventkey is missing.Long one (more context)
I'm new to python development in general. I am adding
structlogto myuvicornapp, so that the logs are parseable by the logs processor. My current orgs setup expectmessagekey, hence I am usingEventRenamer. But when my logger get passedNoneor[](empty array), it will break the logger.Other considerations and questions:
Maybe let
Nonebe passed asevent?In the
_base.py_process_event, there's this if-clause.I wonder why do this?
Other approach
I've added new custom processors like this:
Pull Request Check List
I haven't done anything more than just this small change. I would like to validate my understanding first.
mainbranch – use a separate branch!api.py.docs/api.rstby hand.versionadded,versionchanged, ordeprecateddirectives..rstand.mdfiles is written using semantic newlines.