refactor!: Remove consul sdk dep #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandenburger
added
cleanup
mbrandenburger
force-pushed
the
remove-freeport
branch
from
f45558d to
eb4af14
Compare
Member
Author
|
|
mbrandenburger
force-pushed
the
remove-freeport
branch
6 times, most recently
from
a8a8f69 to
4ab0cef
Compare
Some postgres test uses a helper function from the consul sdk to get a free network port to start a postgres container instance; to reduce code dependencies, we let the container runtime to select a free port. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
remove-freeport
branch
from
4ab0cef to
88daa32
Compare
mbrandenburger
changed the title
Member
Author
|
@AkramBitar this PR addresses the postgres issue you experienced in #1033. I've integrated your changes to gracefully shutdown a postgres container. |
SaidAltury-ibm
approved these changes
Nov 18, 2025
Contributor
SaidAltury-ibm
left a comment
SaidAltury-ibm
left a comment
There was a problem hiding this comment.
This is neat! great work LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the postgres container code. In particular, it removes a consul sdk dep to pick a free port for the postgres instances we run within NWO and unit-tests. We let NWO select a free container port or let the container runtime select the port during unit-tests.
This PR contributes to #828 and #434
Overview:
postgres.DefaultConfigNote
This PR changes the API of
postgres.DefaultConfig, which is also used by the TokenSDK for testing.