dlog v1 finalization: check the IssueAction against the passed metadata. #940 #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecaro
force-pushed
the
940-dlog-v1-finalization-check-the-issueaction-against-the-passed-metadata
branch
3 times, most recently
from
6e8a3da to
f0386ee
Compare
adecaro
force-pushed
the
940-dlog-v1-finalization-check-the-issueaction-against-the-passed-metadata
branch
2 times, most recently
from
40613fd to
89c6f49
Compare
adecaro
force-pushed
the
940-dlog-v1-finalization-check-the-issueaction-against-the-passed-metadata
branch
3 times, most recently
from
3f8ac60 to
1f4eaf8
Compare
AkramBitar
reviewed
Nov 10, 2025
| // VerifyIssue checks if the outputs of an IssueAction match the passed tokenInfos | ||
| func (s *IssueService) VerifyIssue(tr driver.IssueAction, metadata []*driver.IssueOutputMetadata) error { | ||
| func (s *IssueService) VerifyIssue(ctx context.Context, ia driver.IssueAction, metadata []*driver.IssueOutputMetadata) error { | ||
| // TODO: |
Contributor
There was a problem hiding this comment.
I am wondering if to add debug message that says "this method is not implemented".
Contributor
Author
There was a problem hiding this comment.
it definitely needs to be implemented and it can be a good task for the team.
Contributor
Author
There was a problem hiding this comment.
@HayimShaul , please, take the task on. Thanks.
Contributor
Author
There was a problem hiding this comment.
your concern was about the implementation of the function, no?
Contributor
Author
There was a problem hiding this comment.
but good point, please, identify the TODOs in the code, classify them in category so that we can assign priorities and address. Thanks much.
AkramBitar
approved these changes
Nov 12, 2025
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
940-dlog-v1-finalization-check-the-issueaction-against-the-passed-metadata
branch
from
1f4eaf8 to
dc4199b
Compare
adecaro
deleted the
940-dlog-v1-finalization-check-the-issueaction-against-the-passed-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #940