-
Notifications
You must be signed in to change notification settings - Fork 47
DR docs command correction and clarification #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DR docs command correction and clarification #2680
Conversation
Signed-off-by: tarikBensalem-DA <tarik.bensalem@digitalasset.com>
7dd893a to
06abca3
Compare
Co-authored-by: Itai Segall <itai.segall@digitalasset.com> Signed-off-by: tarikBensalem-DA <164049054+tarikBensalem-DA@users.noreply.github.com>
Signed-off-by: tarikBensalem-DA <164049054+tarikBensalem-DA@users.noreply.github.com>
| val parties = participant.parties.list (<participantIdentifier>) | ||
| You can assign a party to a variable using the following command, where <index> is the zero-based position of the party in the list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we remove this. They need to have separate consoles open (one for the old participant, one for the new), so I don't know if writing to a variable will really be of help to anyone...
martinflorian-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarikBensalem-DA this PR has gotten a bit stale and now has conflicts with main... LMK if you want to get it merge-ready again, if not I suggest we close it.
Also FYI: past and ongoing improvements to the recover-from-key process:
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines