WIP: preapprovals standard #2709
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiersi-da
commented
Oct 15, 2025
| choice TransferPreapproval_Renew : TransferPreapprovalResult | ||
| -- ^ Renew the preapproval as the receiver. | ||
| -- | ||
| -- IMPL. IDEA: |
Contributor
Author
There was a problem hiding this comment.
TODO: define behavior
meiersi-da
force-pushed
the
meiersi/daml/preapprovals
branch
from
0c272f0 to
4758f93
Compare
meiersi-da
commented
Oct 16, 2025
| -- FIXME: test that reason arg is checked, and add it | ||
| meta = emptyMetadata | ||
| context = | ||
| -} |
johan-da
reviewed
Nov 7, 2025
| -- ^ Accept the transfer preapproval as the admin or wallet provider. | ||
| with | ||
| actor : Party | ||
| -- ^ The party executing the cancellation. |
There was a problem hiding this comment.
Suggested change
| -- ^ The party executing the cancellation. | |
| -- ^ The party executing the acceptance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines