-
Notifications
You must be signed in to change notification settings - Fork 48
Daml: Enhance DsoRules to allow weight change and withdrawal of ValidatorLicense #3011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dfordivam
wants to merge
16
commits into
hyperledger-labs:meiersi/dn/feature-cip-73
Choose a base branch
from
obsidiansystems:dn/cip-0073-daml-vl-weight-change-withdraw
base: meiersi/dn/feature-cip-73
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0dbe1f9
Daml: Add DsoRules for ValidatorLicense weight change and withdrawal
dfordivam 8a9d2fa
Daml: add expiresAt to ValidatorLicense_Instruction and DsoRules_Expi…
dfordivam 78eb2ca
Require non-zero
dfordivam ad93657
Move tests to existing file and fix test with 0 weight
dfordivam a6ac9b6
Add test for weight 0 rejection
dfordivam 6b4307b
Fix warnings
dfordivam 9bd6b89
Remove validatorLicenseInstructionTimeout
dfordivam 96e01b2
update daml/dars
dfordivam 20c462b
Add instance HasCheckedFetch ValidatorLicense ForOwner
dfordivam 4d15729
vote execution changes
dfordivam e88238a
Add instance HasCheckedFetch ValidatorLivenessActivityRecord ForDso
dfordivam f634b00
Replace use of fetchUncheckedAndArchive
dfordivam 7e113aa
Add executeAllVoteExecutionInstructions
dfordivam 4add2fb
Fix warning
dfordivam 0032575
Move weight check to ValidatorLivenessActivityRecord
dfordivam 2ddee02
Add test for VoteExecutionInstruction_Expire
dfordivam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing test: instruction expiry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
testVoteExecutionInstructionExpire