pax/chain predeploy #384

pgreen88 · 2025-10-21T14:21:47Z

configurable predeploy + custom deployed option

nick1udwig

I like the direction you're going here. Added some comments. In general we need to make sure we make it clear to users How to use this feature without reading kit code. Right now it is not clear at all

E.g.:

How to I acquire the contract code I need to deploy it on the fakechain?
How do I learn the format of the file I need to use for the config file?

nick1udwig · 2025-10-23T04:38:36Z

src/chain/mod.rs

    .await?;

+    // Always try to load default config
+    let default_config = load_config(&PathBuf::from(DEFAULT_CONFIG_PATH))?;


instead of loading this from a path (which happens at run-time, where kit may be running in an arbitrary directory), you're going to want to include_str! it, which includes it at compile-time (and so guarantees you'll have access to it at run-time). See example usage

https://github.com/hyperware-ai/hyperdrive/blob/60d8715d94da8801eae1ddc4b23c3a41cf305355/hyperdrive/src/main.rs#L56

https://github.com/hyperware-ai/hyperdrive/blob/60d8715d94da8801eae1ddc4b23c3a41cf305355/hyperdrive/src/main.rs#L132

nick1udwig · 2025-10-23T04:40:42Z

src/chain/mod.rs

-    (HYPERMAP_PROXY, include_str!("./bytecode/erc1967proxy.txt")),
-    (HYPERMAP, include_str!("./bytecode/hypermap.txt")),
-];
+const PREDEPLOY_CONTRACTS: &[(&str, &str)] = &[];


no reason to keep these or the logic that uses them around if they are gone now

yes, will remove all txt configs

nick1udwig · 2025-10-23T04:42:10Z

src/chain/mod.rs


+// Public function without custom config
 #[instrument(level = "trace", skip_all)]
 pub async fn start_chain(


we should remove this and rename start_chain_with_config to start_chain (and update the callers to pass in None

agree, will do once we have working POC

Ok lets update this now

nick1udwig · 2025-10-23T04:43:08Z

src/main.rs

+                .action(ArgAction::Set)
+                .short('c')
+                .long("config")
+                .help("Path to contracts config file (TOML format)")


it isn't obvious from this helptext that what is happening is we are configuring additional contracts with the same form as the default. Update the helptext to be more descriptive here

src/Contracts.toml

…in custom config

This reverts commit 65597a2.

This reverts commit 3d80d04.

This reverts commit 431afd2.

nick1udwig · 2025-11-06T23:40:29Z

src/chain/readme.md

+
+3. Deploy missing contracts if needed
+
+## Troubleshooting


remove this section

nick1udwig · 2025-11-06T23:42:34Z

src/chain/readme.md

How to make the contract files from Solidity? Give examples in foundry and 1 other framework

In general this doc is great for what it covers, but it doesn't tell me how to go from some solidity smart contracts or transactions I want to run to stuff I can plug in here

nick1udwig · 2025-11-06T23:53:46Z

src/chain/mod.rs


+// Public function without custom config
 #[instrument(level = "trace", skip_all)]
 pub async fn start_chain(


Ok lets update this now

nick1udwig · 2025-11-06T23:55:01Z

src/chain/mod.rs

+}
+
+#[instrument(level = "trace", skip_all)]
+pub async fn verify_contracts(port: u16, addresses: &ContractAddresses) -> Result<()> {


We need to either generalize this function or else rename it: right now all it does is verify hypermap

nick1udwig · 2025-11-07T00:55:20Z

src/chain/mod.rs

    )
    .await?;

+    let default_config = load_default_config().ok();


This should never fail. Don't .ok(), just ?

nick1udwig · 2025-11-07T00:59:10Z

src/chain/mod.rs

+
+#[instrument(level = "trace", skip_all)]
+async fn check_dot_os_tba(port: u16) -> Result<bool> {
+    let dot_os_tba = "0x9b3853358ede717fc7D4806cF75d7A4d4517A9C9";


This should be a const defined at top of file

Or better yet read in from config file

Probably this function should be generalized and take the address as an argument

nick1udwig · 2025-11-07T01:02:26Z

src/chain/mod.rs

+            sleep(Duration::from_millis(200)).await;
+
+            // Calculate token ID from label (.os)
+            let token_id_hex = "0xdeeac81ae11b64e7cab86d089c306e5d223552a630f02633ce170d2786ff1bbd";


there are lots of these magic numbers throughout the code. These should all either be pulled from the config or defined as const at the top of the file

nick1udwig · 2025-11-07T01:04:23Z

src/chain/mod.rs

+        Ok(tx_hash) => {
+            info!("Mint NFT transaction sent: {}", tx_hash);
+
+            sleep(Duration::from_millis(200)).await;


We need a more robust solution here. Ideally we would have a way to tell that we are ready to proceed by querying the chain. Worst case, we should sleep-retry until ready

nick1udwig · 2025-11-07T01:04:57Z

src/chain/mod.rs

+            }
+        }
+        Err(e) => {
+            info!("Mint NFT transaction failed: {}", e);


Is this the proper logging level to use in this case?

nick1udwig · 2025-11-07T01:07:04Z

src/chain/mod.rs

+    );
+
+    let client = Client::new();
+    let _impersonator = AnvilImpersonator::new(port, &client, OWNER_ADDRESS).await?;


do we actually need to impersonate here since we execute_transaction with OWNER_ADDRESS as from in L709?

nick1udwig · 2025-11-07T01:20:20Z

This breaks networking between fake nodes. I think what is going on is that everything gets re-deployed when you start a second fake node. This needs to be fixed before merging

Look at this page for an example of how two boot two fake nodes: https://book.hyperware.ai/getting_started/quick_start.html

On master, you can then do, e.g.,

hi fake.os hello

from the second fakenode and it will properly message fake.os

On this branch they cannot see each other, like I said, probably because the chain gets reset? Could also have broken if you changed how new fake nodes register on the chain when they boot

pgreen88 · 2025-11-14T13:07:48Z

Fixed running two fake nodes together on the same network but it also must be fixed on hyperdrive level, it has hardcoded dotOs address that is different from the kit one. Ideally we have to use hypermap.tbaOf(dotOstokenId)

Pax G and others added 2 commits October 21, 2025 07:19

enabled predeploy configuration

e457ff8

Format Rust code using rustfmt

9702b06

nick1udwig requested changes Oct 23, 2025

View reviewed changes

Pax G and others added 27 commits October 23, 2025 08:14

draft poc

782f6f0

Format Rust code using rustfmt

974eec4

predeploy + setup + custom transactions

2807797

fixed custom config bug + made contracts from default config visible …

724cf78

…in custom config

Format Rust code using rustfmt

76cba31

fixed typo

a4e1801

add hyperapp skeleton to templates

26fd5db

template

e8dea4d

Format Rust code using rustfmt

1512b8c

add resources

9cf72c3

rename hyperapp-skeleton to hyperapp

ee0911f

remove pkg/ui and add to gitignore

abb2744

remove garbage from example-apps/id/id

812a549

rename back from hyperapp to hyperapp-skeleton

5f7f2a6

remove machine generated api folder

8ddaa5e

fix icon

20478ca

remove obsolete comments.

66a9ae5

remove api.ts and wire backend calls correctly

7dcd929

wit_world fix

aefc83f

remove useless request_body args

81bebef

remove file explorer

ae46409

update file explorer

dda6286

gitignore cleanup

6bd6e35

remove pkg/ui from file explorer

3dcaa5b

clean up cargo tomls in hyperapp skeleton

4d27fe0

remove types/skeleton.ts

c5a4d53

remove CHANGES_MADE.md

2512b17

jurij-jukic and others added 19 commits October 31, 2025 01:43

remove expand-sign-old.txt

682e106

remove caller utils from file explorer example

06c54c1

Revert "remove types/skeleton.ts"

05f807c

This reverts commit 65597a2.

remove api stuff from types/skeleton.ts and some readme updates

af16789

update readme re file explorer api

b9982eb

hyperapp skeleton template renaming

b069132

hyperapp can return any type, not just result

8a5081f

fix color coding of errors

538619c

debug to display

eb78831

Revert "debug to display"

b79a4e4

This reverts commit 3d80d04.

add error attr, remove manual display formatting

88411eb

ai generated changes fix the issue

bd67c13

Revert "fix color coding of errors"

321090c

This reverts commit 431afd2.

Format Rust code using rustfmt

333021e

change formatting for cleaner diff

a36568b

added config to boot-fake-node and fixed related issues

afa6629

added readme

38dfbca

removed old default config

de0128e

Merge branch 'develop' into pax/chain-predeploy

9c9973f

nick1udwig requested changes Nov 7, 2025

View reviewed changes

Pax G and others added 5 commits November 12, 2025 06:22

pr comment fixes

3007321

Format Rust code using rustfmt

3555282

moved magic values to constans

c8acfca

fixed comments

c97a831

Format Rust code using rustfmt

906b06a

Merge branch 'develop' into pax/chain-predeploy

b237dab

pax/chain predeploy #384

Are you sure you want to change the base?

pax/chain predeploy #384

Uh oh!

Conversation

pgreen88 commented Oct 21, 2025

Uh oh!

nick1udwig left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nick1udwig commented Nov 7, 2025

Uh oh!

pgreen88 commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants