feat: make dynamic bucket region detection optional#549
Open
sasanyasari wants to merge 8 commits intohypnoglow:masterfrom
Open
feat: make dynamic bucket region detection optional#549sasanyasari wants to merge 8 commits intohypnoglow:masterfrom
sasanyasari wants to merge 8 commits intohypnoglow:masterfrom
Conversation
Add HELM_S3_DYNAMIC_REGION environment variable to control automatic bucket region detection. Defaults to true for backward compatibility. This addresses several issues: - Prevents plugin failures in restricted internet environments - Stops leaking internal bucket names to AWS in non-restricted environments - Allows users to disable automatic S3 HEAD requests that always go to Amazon S3 regardless of custom endpoints or AWS configuration Setting HELM_S3_DYNAMIC_REGION=false disables dynamic region detection and relies on standard AWS region configuration (HELM_S3_REGION, AWS_REGION, AWS_DEFAULT_REGION). Fixes hypnoglow#220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add support for disabling dynamic bucket region detection via the
HELM_S3_DYNAMIC_REGIONenvironment variable.Problem
The current implementation of
DynamicBucketRegionalways performs automatic bucket region detection by making HEAD requests to Amazon S3, which causes several issues:s3.amazonaws.coms3.amazonaws.com) regardless of custom endpoints configured viaAWS_ENDPOINTor AWS profilesSolution
Introduce
HELM_S3_DYNAMIC_REGIONenvironment variable:true(enabled) - maintains backward compatibilityfalse: Disables dynamic region detection, relies on standard AWS region configurationChanges
ConditionalDynamicBucketRegion()function that respects the new environment variableUsage
To disable dynamic bucket region detection:
export HELM_S3_DYNAMIC_REGION=falseThis is particularly useful for:
Testing
All existing tests pass, and new tests verify:
Backward Compatibility
✅ Fully backward compatible - existing users will see no change in behavior unless they explicitly set
HELM_S3_DYNAMIC_REGION=false.Fixes #220