-
Notifications
You must be signed in to change notification settings - Fork 289
Feature/mpt 15116/udate assumed role connect form #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mpt 15116/udate assumed role connect form #772
Conversation
Wrong params were sent for Assumed Role - Member data Source.
… translation file
…ifiers and conditional rendering
ek-hystax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
One more note regarding naming: I don't think it’s necessary to include the component/folder name in the AWSConnectionForm files for types, styles, and constants.
Also, the styles file, in particular, might be removed eventually once the related concerns are resolved.
It’s fine to keep the names simple:
* AwsConnectionForm.constants.tsx → constants.ts
* AwsConnectionForm.types.tsx → types.ts
* AwsConnectionForm.styles.ts → styles.ts
ngui/ui/src/components/DataSourceCredentialFields/AwsAssumedRoleInputs/AwsAssumedRoleInputs.tsx
Outdated
Show resolved
Hide resolved
ngui/ui/src/components/forms/ConnectCloudAccountForm/ConnectCloudAccountForm.tsx
Outdated
Show resolved
Hide resolved
ngui/ui/src/components/forms/ConnectCloudAccountForm/ConnectCloudAccountForm.tsx
Outdated
Show resolved
Hide resolved
ngui/ui/src/components/forms/ConnectCloudAccountForm/ConnectCloudAccountForm.tsx
Show resolved
Hide resolved
...nts/forms/ConnectCloudAccountForm/FormElements/AwsConnectionForm/AwsConnectionForm.styles.ts
Outdated
Show resolved
Hide resolved
…entation references and improve option naming.
ngui/ui/src/components/forms/UpdateDataSourceCredentialsForm/FormElements/CredentialInputs.tsx
Show resolved
Hide resolved
ngui/ui/src/components/forms/ConnectCloudAccountForm/FormElements/AwsConnectionForm/index.tsx
Outdated
Show resolved
Hide resolved
ngui/ui/src/components/forms/ConnectCloudAccountForm/ConnectCloudAccountForm.tsx
Outdated
Show resolved
Hide resolved
Remove not needed fields from ConnectCloudAccountForm payload
ngui/ui/src/components/forms/ConnectCloudAccountForm/ConnectCloudAccountForm.tsx
Outdated
Show resolved
Hide resolved
…oudAccountForm.tsx Co-authored-by: ek-hystax <33006768+ek-hystax@users.noreply.github.com>
Description
Summary
Enhanced the cloud account connection form with improved authentication options, better account type handling, and comprehensive TypeScript support. This update introduces new authentication tabs for AWS connections and improves the overall developer experience.
Key Features Added
ngui/ui/vite.config.mtsto ensure proper local development. Fixed path rewriting to maintain /api endpoints while removing prefix for other routesRelated issue number
Special notes
Checklist