Skip to content

Conversation

@dwolosz
Copy link
Contributor

@dwolosz dwolosz commented Nov 4, 2025

Description

image

Summary

Enhanced the cloud account connection form with improved authentication options, better account type handling, and comprehensive TypeScript support. This update introduces new authentication tabs for AWS connections and improves the overall developer experience.

Key Features Added

  • New Authentication Tabs: Added "Assumed Role" and "Access Key" authentication options for AWS connections
  • Updated Account Type Tabs: Enhanced Management, Member, and Standalone account type selection
  • Improved Authentication Flow: Better separation between different AWS authentication methods with proper form validation
  • Cloud Connect Form Help: Added comprehensive help descriptions and guidance for each connection type
  • TypeScript Annotations: Added comprehensive type definitions throughout the form components and improved component props interfaces and function parameter typing
  • Vite Configuration Update: Enhanced proxy rewrite logic in ngui/ui/vite.config.mts to ensure proper local development. Fixed path rewriting to maintain /api endpoints while removing prefix for other routes
rewrite: (p) => {
  return p == '/api' ? p : p.replace(/^\/api/, "/");

Related issue number

Special notes

Checklist

  • The pull request title is a good summary of the changes
  • Unit tests for the changes exist
  • New and existing unit tests pass locally

Copy link
Contributor

@ek-hystax ek-hystax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

One more note regarding naming: I don't think it’s necessary to include the component/folder name in the AWSConnectionForm files for types, styles, and constants.

Also, the styles file, in particular, might be removed eventually once the related concerns are resolved.

It’s fine to keep the names simple:

* AwsConnectionForm.constants.tsx → constants.ts
* AwsConnectionForm.types.tsx → types.ts
* AwsConnectionForm.styles.ts → styles.ts

@dwolosz dwolosz marked this pull request as ready for review November 13, 2025 14:39
Remove not needed fields from ConnectCloudAccountForm payload
…oudAccountForm.tsx

Co-authored-by: ek-hystax <33006768+ek-hystax@users.noreply.github.com>
@stanfra stanfra merged commit c79fcc2 into hystax:integration Dec 11, 2025
1 check passed
@dwolosz dwolosz deleted the feature/MPT-15116/udate-assumed-role-connect-form branch December 11, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants