New subcollimator transmission #241
Conversation
samaloney
left a comment
samaloney
left a comment
There was a problem hiding this comment.
So I did a quick once over and this looks good but we need to a file somewhere which does the analysis to generate these the files used.
|
Do you mean that we should make public the code we used to compute the slope and intercept values stored in this file? If so, I can certainly do that. I plan to include and publish the code as part of the paper on the grid calibration. |
|
I changed this PR back to draft as we realized that we need to modify the visibility amplitude calibration when we use the new transmission values. |
There was a problem hiding this comment.
Pull request overview
This pull request implements a new subcollimator transmission calculation method for STIX. The transmission is computed differently for low and high energy ranges: at low energies, it uses a linear fit based on fully illuminated CFL pixel data as a function of off-axis angle; at high energies, it employs a wedge-shaped geometry model to account for grid imperfections.
Changes:
- Replaced the previous internal shadowing model with a dual-approach transmission calculation based on energy range
- Added new calibration data file (CFL_subcoll_transmission.txt) containing intercept and slope parameters for linear fits
- Simplified the grid transmission function to focus on the wedge model for high energies
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| stix/idl/processing/subcollimator/stx_subc_transmission.pro | Major refactor to implement new transmission calculation using CFL-based linear fits for low energies and wedge model for high energies |
| stix/idl/processing/subcollimator/stx_grid_transmission.pro | Simplified function signature and implementation to support the new wedge-based grid transmission model |
| stix/dbase/grid/CFL_subcoll_transmission.txt | New calibration data file containing intercept and slope parameters for 32 subcollimators |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tors 1(a,b,c), 2(a,b,c), CFL, and BKG.
So can expect a additional PR to update the that and then this PR will be updated |
2 participants
New subcollimator transmission:
At low energies, the transmission is estimated by comparing A+B+C+D to the total flux derived from fully illuminated CFL data across a set of flaring events. Specifically, the subcollimator transmission is obtained through a linear fit as a function of the off-axis angle.
At high energies, the subcollimator transmission is determined by modeling grid imperfections using a wedge-shaped geometry. The wedge parameters are obtained by fitting data from multiple flaring events.
Details about the derivation of the subcollimator transmission will be described in upcoming papers.