Compile on MacOS by adding ARM64 to Xdr.cc and removing binary_function #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I can confirm again this works. @tmadlener or @andresailer if I can get this merged and a tag it would be very nice 😃 |
Contributor
|
Looks like an upgrade of CI workflows is necessary here, since nothing has happened "recently". Let me do that and then merge this as well before making a tag. |
(binary_function has been removed in C++17)
tmadlener
approved these changes
Jan 10, 2025
Contributor
Author
|
I have added the version to my spack locally. I have a bunch of changes that I'll make at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Having a tag after this PR would be great, then I don't need to patch the recipe :)