Skip to content

DDTPCDigiProcessor.cc : reduce redundant loading of geometry info #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmadlener merged 2 commits into from
Jun 20, 2025
Merged

DDTPCDigiProcessor.cc : reduce redundant loading of geometry info #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa30b6
reduce number of times geometry info is loaded
danieljeans Jun 20, 2025
7d2768e
const definition
danieljeans Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions source/Digitisers/src/DDTPCDigiProcessor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,10 @@ void DDTPCDigiProcessor::processEvent(LCEvent* evt) {
} catch (DataNotAvailableException& e) {
}

const FixedPadSizeDiskLayout padLayout(_tpc);
const double TPCPadPlaneRMin = _tpc->rMinReadout / dd4hep::mm;
const double TPCPadPlaneRMax = _tpc->rMaxReadout / dd4hep::mm;

float edep0 = 0.0;
if (STHcol != 0) {
int n_sim_hits = STHcol->getNumberOfElements();
Expand Down Expand Up @@ -638,12 +642,8 @@ void DDTPCDigiProcessor::processEvent(LCEvent* evt) {
double tpcZRes =
sqrt((_pointResoZ0 * _pointResoZ0) + (_diffZ * _diffZ) * (driftLength / 10.0)); // driftLength in cm

FixedPadSizeDiskLayout padLayout(_tpc);
int padIndex = padLayout.getNearestPad(thisPoint.perp(), thisPoint.phi());

double TPCPadPlaneRMin = _tpc->rMinReadout / dd4hep::mm;
double TPCPadPlaneRMax = _tpc->rMaxReadout / dd4hep::mm;

int iRowHit = padLayout.getRowNumber(padIndex);
int iPhiHit = padLayout.getPadNumber(padIndex);

Expand Down Expand Up @@ -717,11 +717,6 @@ void DDTPCDigiProcessor::processEvent(LCEvent* evt) {

CLHEP::Hep3Vector thisPoint(_SimTHit->getPosition()[0], _SimTHit->getPosition()[1], _SimTHit->getPosition()[2]);

FixedPadSizeDiskLayout padLayout(_tpc);
const std::vector<double>& planeExt = padLayout.getPlaneExtent();
double TPCPadPlaneRMin = planeExt[0];
double TPCPadPlaneRMax = planeExt[1];

int NBinsZ = (int)((2.0 * _tpc->driftLength / dd4hep::mm) / _binningZ);

if ((thisPoint.perp() < TPCPadPlaneRMin) || (thisPoint.perp() > TPCPadPlaneRMax)) {
Expand Down Expand Up @@ -1308,7 +1303,7 @@ void DDTPCDigiProcessor::plotHelixHitResidual(MCParticle* mcp, CLHEP::Hep3Vector
int row = padLayout.getRowNumber(padLayout.getNearestPad(thisPoint->perp(), thisPoint->phi()));
int pad = padLayout.getNearestPad(thisPoint->perp(), thisPoint->phi());

double rHit_diff = thisPoint->perp() - padLayout.getPlaneExtent()[0] - ((row + 0.5) * _tpc->padHeight / dd4hep::mm);
double rHit_diff = thisPoint->perp() - TPCPadPlaneRMin - ((row + 0.5) * _tpc->padHeight / dd4hep::mm);

_radiusCheckHisto->fill(rHit_diff);

Expand Down