Fix SecurityCraft compatibility and Stitch dependency issues #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace @overwrite with @Inject for onChunkReadyToSend method to prevent mixin conflicts with SecurityCraft - Add Fabric Maven repository for net.fabricmc dependencies - Fix Stitch library dependency (changed from maven.modrinth:stitch:4.0.1 to net.fabricmc:stitch:0.6.2) These changes resolve server crash when SecurityCraft is installed alongside Immersive Portals. Fixes mixin injection conflict that prevented SecurityCraft from applying its camera-related mixins. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical compatibility issues that cause server crashes when Immersive Portals is used
alongside SecurityCraft and resolves build failures due to incorrect Stitch library configuration.
Changes
@Overwritewith@Injectannotation inMixinChunkMap_C.javafor theonChunkReadyToSendmethodnet.fabricmcdependencies (wasn't found in maven while building)maven.modrinth:stitch:4.0.1tonet.fabricmc:stitch:0.6.2Problem Solved
MixinApplyErrorwhen SecurityCraft tries to inject intoonChunkReadyToSendmethodTesting
./gradlew compileJavaError Details
The original error occurred because SecurityCraft's
ChunkMapMixincouldn't inject intoonChunkReadyToSendmethod due to Immersive Portals using@Overwritewith the same priority (1100).This PR changes the approach to use
@Injectwith cancellation, allowing other mods to also hook intothis method without conflicts.
Related Issues
Fixes compatibility with SecurityCraft mod and resolves build dependency issues.