Fix upload with multiple blocks to allow more than 60mb#72
Open
sharevb wants to merge 12 commits intoiamleot:masterfrom
Open
Fix upload with multiple blocks to allow more than 60mb#72sharevb wants to merge 12 commits intoiamleot:masterfrom
sharevb wants to merge 12 commits intoiamleot:masterfrom
Conversation
|
It seems there is a limit to the number of blocks you can send. The file I want to send is a unique zip file of size 890M. |
Contributor
Author
|
Right dont work with big big files, will update with your chunked solution @antoinedelplace, merci |
As of issue iamleot#76, PR iamleot#77 and to accomodate issue iamleot#64, thus case of "many small" or "really big" files, chunk big files in many blocks and blocks request also in chunks if more than 100 blocks need for the transfer of all files
9a0c34b to
e193115
Compare
Contributor
Author
|
So right now, @antoinedelplace , should be ok either with 600 files or a big 800MB zipped |
Contributor
Author
|
@iamleot, could you please merge this PR, will solve many things, thanks |
Closed
Contributor
Author
|
Just updated to accomodate with #78 |
|
Works for my 143 MB file. Thanks! |
Contributor
Author
|
@iamleot, could you please merge this PR, will solve many things, thanks |
|
Changed the file contents based on this Fix and I am happy to say that the upload is now working, no more errors. Great work. |
Contributor
Author
|
@iamleot, could you please merge this PR, will solve many things, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #64, #70