refactor(all)!: convert to ESM #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamludal
requested changes
May 28, 2024
| node_modules/ | ||
| dist/ | ||
| yarn-error.log | ||
| package-lock.json |
Owner
There was a problem hiding this comment.
Lockfiles should not be added to gitignore as they allow to pin specific versions of dependencies, preventing to download different versions when running 2 times "npm install" at different times but from the same source code
| "dependencies": { | ||
| "@semantic-release/error": "2.2.0", | ||
| "@semantic-release/release-notes-generator": "^10.0.3", | ||
| "aggregate-error": "^4.0.1" |
Owner
There was a problem hiding this comment.
We don't need this dependency anymore?
| const jiraHost = pluginConfig[INPUTS.jiraHost]; | ||
| const errors = []; | ||
|
|
||
| const AggregateError = (await AggregateErrorPromise).default; |
Owner
There was a problem hiding this comment.
Don't we need this class anymore? We are using it a line 32 🤔
Owner
|
Hi! Many thanks for your contribution. I've reviewed your PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR converts this package to ESM/module syntax, as well as: