chore: change dependencies to resolve dependencies from peers of semantic release #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossreicks
changed the title
adumat
reviewed
Sep 26, 2024
| "aggregate-error": "^5.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "semantic-release": "^21.0.0" |
There was a problem hiding this comment.
is it correct to place on peerDependencies also @semantic-release/release-notes-generator, @semantic-release/error and aggregate-error ?
|
you should at least do a commit with fix or feat to trigger the bump of release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semantic release version 24 changed their api causing release notes generator to have to update.
Because semenatic release has dependencies on all the same dependencies, we can instead just say we have a peer dependency on those dependencies and depending on what version of semantic release a user has, we can use that version. This way this repo doesnt have to update every update semantic release has.