Conversation
It's non trivial to determine where the "prompt" line is.
When we have reverse/default layout, info/header/footer border
This is a workaround for user find the prompt hl annoying:
opts.command_history._treesitter = function(line, lnum)
if lnum == 1 then return end
return line:match("(.-):?(%d+)[: ](.+)$")
end
📝 WalkthroughWalkthroughThe changes extend the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
lua/fzf-lua/win/tsinjector.lua (1)
130-131:⚠️ Potential issue | 🟡 MinorUpdate parameter type annotation for
line_parser.The
line_parserparameter type annotation at line 130 also needs updating to include thelnumparameter. This will resolve the remaining[redundant-parameter]warning at line 174.🔧 Proposed fix
----@param line_parser (fun(line: string):string?,string?,string?,string?)|boolean? +---@param line_parser (fun(line: string, lnum: integer):string?,string?,string?,string?)|boolean? ---@return function detach🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lua/fzf-lua/win/tsinjector.lua` around lines 130 - 131, Update the type annotation for the parameter named line_parser in tsinjector.lua to include the lnum argument (e.g., change (fun(line: string):string?,string?,string?,string?)|boolean? to a signature that accepts (line: string, lnum: number) and returns the four optional strings or nil); locate the annotation above the function that declares/detects line_parser and add the lnum parameter to match the runtime usage (this will remove the [redundant-parameter] warning at the call site around line 174).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lua/fzf-lua/win/tsinjector.lua`:
- Around line 135-136: The type annotation for default_line_parser is out of
sync with its implementation and types.lua: update the local annotation for
default_line_parser to include the second parameter (lnum) so the signature
matches the actual function (e.g., fun(line: string, lnum: number):
string?,string?,string?,string?) and remove the redundant-parameter warning;
target the annotation immediately above the default_line_parser function to
correct the mismatch.
- Line 174: Update the _treesitter parser functions to accept the second ignored
parameter by changing their signatures from function(line) to function(line, _);
specifically modify the _treesitter implementations named git_log,
command_history, and search_history (the functions currently declared with a
single parameter) so they match the default tsinjector.lua signature
function(line, _) and thereby explicitly accept the lnum/second argument passed
by line_parser(line:sub(min_col), i).
---
Outside diff comments:
In `@lua/fzf-lua/win/tsinjector.lua`:
- Around line 130-131: Update the type annotation for the parameter named
line_parser in tsinjector.lua to include the lnum argument (e.g., change
(fun(line: string):string?,string?,string?,string?)|boolean? to a signature that
accepts (line: string, lnum: number) and returns the four optional strings or
nil); locate the annotation above the function that declares/detects line_parser
and add the lnum parameter to match the runtime usage (this will remove the
[redundant-parameter] warning at the call site around line 174).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 36a25265-8532-4dd9-bb2f-538977ff4db4
📒 Files selected for processing (2)
lua/fzf-lua/types.lualua/fzf-lua/win/tsinjector.lua
| ---@type fun(line: string):string?,string?,string?,string? | ||
| local default_line_parser = function(line) return line:match("(.-):?(%d+)[: ](.+)$") end | ||
| local default_line_parser = function(line, _) return line:match("(.-):?(%d+)[: ](.+)$") end |
There was a problem hiding this comment.
Type annotation mismatch causes pipeline warnings.
The local type annotation at line 135 still declares the old signature without lnum, while the actual function at line 136 now accepts two parameters. This is the root cause of the Lua-language-server [redundant-parameter] warnings in the pipeline.
Update the type annotation to match the new signature defined in types.lua:
🔧 Proposed fix
- ---@type fun(line: string):string?,string?,string?,string?
+ ---@type fun(line: string, lnum: integer):string?,string?,string?,string?
local default_line_parser = function(line, _) return line:match("(.-):?(%d+)[: ](.+)$") end📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ---@type fun(line: string):string?,string?,string?,string? | |
| local default_line_parser = function(line) return line:match("(.-):?(%d+)[: ](.+)$") end | |
| local default_line_parser = function(line, _) return line:match("(.-):?(%d+)[: ](.+)$") end | |
| ---@type fun(line: string, lnum: integer):string?,string?,string?,string? | |
| local default_line_parser = function(line, _) return line:match("(.-):?(%d+)[: ](.+)$") end |
🧰 Tools
🪛 GitHub Actions: Lint
[warning] 136-136: Lua-language-server: [redundant-parameter] function expects maximum of 1 argument(s) but receives 2 in function(line, _) return line:match(...).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@lua/fzf-lua/win/tsinjector.lua` around lines 135 - 136, The type annotation
for default_line_parser is out of sync with its implementation and types.lua:
update the local annotation for default_line_parser to include the second
parameter (lnum) so the signature matches the actual function (e.g., fun(line:
string, lnum: number): string?,string?,string?,string?) and remove the
redundant-parameter warning; target the annotation immediately above the
default_line_parser function to correct the mismatch.
| -- line:col:text (grep_curbuf) | ||
| -- line<U+00A0>text (lines|blines) | ||
| local filepath, _lnum, text, _ft = line_parser(line:sub(min_col)) | ||
| local filepath, _lnum, text, _ft = line_parser(line:sub(min_col), i) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find all _treesitter function definitions to verify they handle the new signature
rg -n '_treesitter\s*=' --type=lua -A2Repository: ibhagwan/fzf-lua
Length of output: 2898
🏁 Script executed:
# Check the context around line 174 in tsinjector.lua
sed -n '160,185p' lua/fzf-lua/win/tsinjector.luaRepository: ibhagwan/fzf-lua
Length of output: 1270
🏁 Script executed:
# Find where line_parser is defined/assigned
rg -n 'line_parser\s*=' --type=lua -B3 -A3 lua/fzf-lua/win/tsinjector.luaRepository: ibhagwan/fzf-lua
Length of output: 541
🏁 Script executed:
# Find all _treesitter function definitions with their return values
rg -n 'treesitter\s*=\s*function' --type=lua -A3Repository: ibhagwan/fzf-lua
Length of output: 1262
Update existing _treesitter implementations to explicitly accept the second parameter.
The call site now passes lnum as the second argument to line_parser: line_parser(line:sub(min_col), i). The default implementation in tsinjector.lua already accepts this with function(line, _). However, existing _treesitter implementations in defaults.lua (e.g., git_log at line 812, command_history at line 1909, search_history at line 1928) only declare a single line parameter.
While Lua silently ignores extra arguments and these will continue to work, update them to function(line, _) for consistency with the API contract and the default implementation.
🧰 Tools
🪛 GitHub Actions: Lint
[warning] 174-174: Lua-language-server: [redundant-parameter] function expects maximum of 1 argument(s) but receives 2 in line_parser(line:sub(min_col), i).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@lua/fzf-lua/win/tsinjector.lua` at line 174, Update the _treesitter parser
functions to accept the second ignored parameter by changing their signatures
from function(line) to function(line, _); specifically modify the _treesitter
implementations named git_log, command_history, and search_history (the
functions currently declared with a single parameter) so they match the default
tsinjector.lua signature function(line, _) and thereby explicitly accept the
lnum/second argument passed by line_parser(line:sub(min_col), i).
1 participant
It's non trivial to determine where the "prompt" line is.
When we have reverse/default layout, info/header/footer border
This is a workaround for user find the prompt hl annoying:
Summary by CodeRabbit