[patch] Support Opt-Out Metrics Reporting Flags in GitOps Automation#1857
[patch] Support Opt-Out Metrics Reporting Flags in GitOps Automation#1857ashleytate614 wants to merge 12 commits intomasterfrom
Conversation
|
Closing PR due to old age, if this is still needed please re-open the PR and organize a review via Slack |
ashleytate614
changed the title
| DELETE_WILDCARDS="false" | ||
| fi | ||
| if [[ -z "${MAS_FEATURE_USAGE}" ]]; then | ||
| MAS_FEATURE_USAGE="false" |
There was a problem hiding this comment.
If the flag is missing, i think we should set the default to true
There was a problem hiding this comment.
This is by design. If the flag is set to false Tekton interprets that as an empty string. So we need to set the flag back to false if we get an empty string in Tekton. At this point the flag would be true if it wasn't set yet. I tested this behavior.
https://github.com/ibm-mas/cli/blob/mascore-9752/tekton/src/tasks/gitops/gitops-suite.yml.j2#L324
| MAS_FEATURE_USAGE="false" | ||
| fi | ||
| if [[ -z "${MAS_DEPLOYMENT_PROGRESSION}" ]]; then | ||
| MAS_DEPLOYMENT_PROGRESSION="false" |
There was a problem hiding this comment.
If the flag is missing, i think we should set the default to true
| MAS_DEPLOYMENT_PROGRESSION="false" | ||
| fi | ||
| if [[ -z "${MAS_USABILITY_METRICS}" ]]; then | ||
| MAS_USABILITY_METRICS="false" |
There was a problem hiding this comment.
If the flag is missing, i think we should set the default to true
3 participants
Details
Introduce adoption metrics reporting opt-out flags in GitOps automation used by the SRE team to provision MAS SaaS clusters for customers. These flags are already being implemented in Ansible DevOps and the MAS CLI (separate functions from GitOps automation) and corresponding updates are now required in the GitOps pipeline to ensure consistent configuration management across all provisioning workflows. The changes made in this PR are strictly for the changes needed for GitOps automation.
Test Evidence
See https://github.ibm.com/maximoappsuite/saas-tekton/pull/167 for testing evidence.