Open
Conversation
Contributor
Author
|
I was able to install the cp4d 5.1.3 and upgrade to 5.2.0. I fixed any issue I found but there was no problem with the IBM Licensing operator. Marking this as ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert changes with the target namespace by removing the instance namespace.
Even though this change removes the namespace, it will be added by some internal step during the install so there will always be 2 target namespaces for the IBM licensing operator. ArgoCD is going to ignore the addition so that there won't be anymore restarts on the operator.
Also found and fixed some syntax errors in the upgrade cleanup job.
Tested in noble8 - installed 5.1.3 and then updated to 5.2.0 - Passed
