[patch] create functions to fetch cluster issuer

[terc1997]

Description

• Created the functions getClusterIssuer and getClusterIssuers to support [minor] Support BYO ClusterIssuer cli#1983.

[durera]

Can we also add unittests for the new function to the tests. Don't need you to fill existing test gaps, but we don't want to create more gaps going forward. Use mock framework, and include good/bad path test scenarios.

Also note that delivery is tied to ibm-mas/cli#1983 (review)

We need to update the CLI PR to include the RBAC additions for the new capability that will be used by the CLI user:

https://github.com/ibm-mas/cli/tree/master/rbac/install/user .. the clusterrole will need to be updated to provide the necessary access for the ClusterIssuer resource before this pair of PRs can be merged

[durera]

The typehint is incorrect, this is not returning a string clusterIssuer is the object returned by the clusterIssuerAPI, rather than the name of the issuer.

[terc1997]

In other functions, it's returning a dict. Should we use dict as convention to all or the actual ResourceInstance ?

python-devops/src/mas/devops/ocp.py

Lines 339 to 358 in 8749a84

	def getStorageClass(dynClient: DynamicClient, name: str) -> dict | None:
	"""
	Get a specific StorageClass by name.
	Parameters:
	dynClient (DynamicClient): OpenShift Dynamic Client
	name (str): The name of the StorageClass to retrieve
	Returns:
	StorageClass: The StorageClass resource, or None if not found
	Raises:
	NotFoundError: If the StorageClass does not exist (caught and returns None)
	"""
	try:
	storageClassAPI = dynClient.resources.get(api_version="storage.k8s.io/v1", kind="StorageClass")
	storageclass = storageClassAPI.get(name=name)
	return storageclass
	except NotFoundError:
	return None

[durera]

We are catching a NotFoundError and returning None, so we shouldn't document that this raises NotFoundError ... the documentation should only list exceptions that can be raised by calling the function, not exceptions handling internally within the function.

[terc1997]

Okay, I agree with that. But there are several example in the code that handle the exceptions like this. Fya:

python-devops/src/mas/devops/ocp.py

Lines 416 to 437 in 8749a84

	def crdExists(dynClient: DynamicClient, crdName: str) -> bool:
	"""
	Check if a Custom Resource Definition (CRD) exists in the cluster.
	Parameters:
	dynClient (DynamicClient): OpenShift Dynamic Client
	crdName (str): The name of the CRD to check (e.g., "suites.core.mas.ibm.com")
	Returns:
	bool: True if the CRD exists, False otherwise
	Raises:
	NotFoundError: If the CRD does not exist (caught and returns False)
	"""
	crdAPI = dynClient.resources.get(api_version="apiextensions.k8s.io/v1", kind="CustomResourceDefinition")
	try:
	crdAPI.get(name=crdName)
	logger.debug(f"CRD does exist: {crdName}")
	return True
	except NotFoundError:
	logger.debug(f"CRD does not exist: {crdName}")
	return False

python-devops/src/mas/devops/ocp.py

Lines 339 to 358 in 8749a84

	def getStorageClass(dynClient: DynamicClient, name: str) -> dict | None:
	"""
	Get a specific StorageClass by name.
	Parameters:
	dynClient (DynamicClient): OpenShift Dynamic Client
	name (str): The name of the StorageClass to retrieve
	Returns:
	StorageClass: The StorageClass resource, or None if not found
	Raises:
	NotFoundError: If the StorageClass does not exist (caught and returns None)
	"""
	try:
	storageClassAPI = dynClient.resources.get(api_version="storage.k8s.io/v1", kind="StorageClass")
	storageclass = storageClassAPI.get(name=name)
	return storageclass
	except NotFoundError:
	return None

I just followed the standard of the code. So, should we change all or keep as is ?