Skip to content

[Dark Factory] Implement Sprint 2 by hardening SSE reconnection/error observability, correcting Vitest setup for TypeScript + aliases, introducing complete dark-mode design tokens via Tailwind/CSS variables, and aligning global typography to Inter as the single source of truth.#5

Open
ibuzzardo wants to merge 2 commits intomainfrom
df/job-dlidm1p2

Conversation

@ibuzzardo
Copy link
Owner

Dark Factory -- Automated PR

Generated by pipeline job cmm7p4v6b0006mbk2dlidm1p2
⚠️ This implementation required 2 retry iterations

Implementation Plan

  1. modify Repository-wide
  2. modify src/hooks/use-sse.ts
  3. modify src/hooks/use-sse.ts
  4. modify vitest.config.ts
  5. create src/test/setup.ts
  6. modify package.json
  7. modify tailwind.config.ts
  8. modify src/app/globals.css
  9. modify src/app/layout.tsx
  10. modify src/hooks/use-sse.ts
  11. modify src/app/layout.tsx

Code Review Verdict

⚠️ Not approved -- 6 issue(s) noted

Issues flagged:

  • [critical] package.json: Spec step 6 is not evidenced: no package script/dependency alignment for Vitest was provided (expected test/test:watch/coverage scripts and dependency cleanup). This is a hard compliance miss because test tooling drift is explicitly in scope.
  • [major] src/app/layout.tsx: Spec step 11 is missing: no UI verification checklist/manual test notes for 320px/768px/1280px dark-mode readability and typography consistency were added.
  • [major] src/lib/constants/design-tokens.ts: Font source of truth is inconsistent: typography still references Manrope while app root/Tailwind were moved to Inter. This violates the Inter alignment requirement and can cause split typography behavior across components that consume designTokens.
  • [major] src/app/page.tsx: Hardcoded color classes/gradients remain (bg-[radial-gradient(...)], text-slate-300, border-white/*, bg-white/*). This bypasses semantic tokens and weakens dark-mode token architecture goals from the sprint.
  • [major] src/hooks/use-sse.ts: Type-safety/compliance risk: based on the provided snippet, parsed SSE payloads are cast to PipelineEvent without a shown runtime shape guard before invoking onEvent. Malformed JSON structure could still flow as trusted domain data. Add a runtime validator/type guard and route invalid shapes through onError.
  • [minor] src/hooks/use-sse.ts: buildEventsUrl interpolates projectId directly into a path segment. If IDs can include reserved characters (e.g. /, ?, #), reconnect URL construction can break or become ambiguous. Use encodeURIComponent(projectId) for path safety.

Pipeline Cost

Total: $0.5503 USD

Agent Model Notes
planner gpt-5.3-codex --
coder gpt-5.3-codex --
reviewer gpt-5.3-codex --
tester gpt-5.3-codex --
designer gpt-5.3-codex --
validator gpt-5.3-codex --

This PR was opened automatically by Dark Factory v4.

…play behavior, correcting Vitest configuration, introducing dark-mode design tokens, and aligning Inter font usage across the app while preserving project conventions (TypeScript strictness, Tailwind/shadcn, Zod validation, responsive UI).

Generated by Dark Factory v4 pipeline job cmm7p4v6b0006mbk2dlidm1p2
…/error observability, correcting Vitest setup for TypeScript + aliases, introducing complete dark-mode design tokens via Tailwind/CSS variables, and aligning global typography to Inter as the single source of truth.

Generated by Dark Factory v4 pipeline job cmm7p4v6b0006mbk2dlidm1p2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant