[Dark Factory] Implement Sprint 2 by hardening SSE reconnection/error observability, correcting Vitest setup for TypeScript + aliases, introducing complete dark-mode design tokens via Tailwind/CSS variables, and aligning global typography to Inter as the single source of truth.#5
Open
[Dark Factory] Implement Sprint 2 by hardening SSE reconnection/error observability, correcting Vitest setup for TypeScript + aliases, introducing complete dark-mode design tokens via Tailwind/CSS variables, and aligning global typography to Inter as the single source of truth.#5
Conversation
…play behavior, correcting Vitest configuration, introducing dark-mode design tokens, and aligning Inter font usage across the app while preserving project conventions (TypeScript strictness, Tailwind/shadcn, Zod validation, responsive UI). Generated by Dark Factory v4 pipeline job cmm7p4v6b0006mbk2dlidm1p2
…/error observability, correcting Vitest setup for TypeScript + aliases, introducing complete dark-mode design tokens via Tailwind/CSS variables, and aligning global typography to Inter as the single source of truth. Generated by Dark Factory v4 pipeline job cmm7p4v6b0006mbk2dlidm1p2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark Factory -- Automated PR
Implementation Plan
Repository-widesrc/hooks/use-sse.tssrc/hooks/use-sse.tsvitest.config.tssrc/test/setup.tspackage.jsontailwind.config.tssrc/app/globals.csssrc/app/layout.tsxsrc/hooks/use-sse.tssrc/app/layout.tsxCode Review Verdict
Issues flagged:
package.json: Spec step 6 is not evidenced: no package script/dependency alignment for Vitest was provided (expected test/test:watch/coverage scripts and dependency cleanup). This is a hard compliance miss because test tooling drift is explicitly in scope.src/app/layout.tsx: Spec step 11 is missing: no UI verification checklist/manual test notes for 320px/768px/1280px dark-mode readability and typography consistency were added.src/lib/constants/design-tokens.ts: Font source of truth is inconsistent: typography still references Manrope while app root/Tailwind were moved to Inter. This violates the Inter alignment requirement and can cause split typography behavior across components that consume designTokens.src/app/page.tsx: Hardcoded color classes/gradients remain (bg-[radial-gradient(...)],text-slate-300,border-white/*,bg-white/*). This bypasses semantic tokens and weakens dark-mode token architecture goals from the sprint.src/hooks/use-sse.ts: Type-safety/compliance risk: based on the provided snippet, parsed SSE payloads are cast toPipelineEventwithout a shown runtime shape guard before invokingonEvent. Malformed JSON structure could still flow as trusted domain data. Add a runtime validator/type guard and route invalid shapes throughonError.src/hooks/use-sse.ts:buildEventsUrlinterpolatesprojectIddirectly into a path segment. If IDs can include reserved characters (e.g./,?,#), reconnect URL construction can break or become ambiguous. UseencodeURIComponent(projectId)for path safety.Pipeline Cost
Total: $0.5503 USD
This PR was opened automatically by Dark Factory v4.