-
Notifications
You must be signed in to change notification settings - Fork 8
LBM parallelization #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
LBM parallelization #131
Conversation
00aae74 to
0fc2264
Compare
|
Job Documentation, step Sync to remote on 47a2180 wanted to post the following: View the site here This comment will be updated on new commits. |
0fc2264 to
9947a8d
Compare
22d782d to
ab4e640
Compare
|
Job Precheck, step Clang format on ab4e640 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
ab4e640 to
d708c2b
Compare
- Remove commented-out clone line in LBMMicroscopicZeroGradientBC - Add documentation for _boundary_rank bitmask encoding in LBMBoundaryCondition Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
test/tests/lbm/tests
Outdated
| min_parallel = 4 | ||
| max_parallel = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nijat, min_parallel should be one. The important thing here is to show that a parallel run produces the same output as a serial output. If it doesn't that means there is a bug in the parallel implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have generated gold files with 1 rank
c18f0b9 to
47a2180
Compare
Closes #130