Skip to content

Conversation

@nnrustamo
Copy link
Collaborator

Closes #130

@moosebuild
Copy link

moosebuild commented Jan 20, 2026

Job Documentation, step Sync to remote on 47a2180 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Jan 20, 2026

Job Coverage, step Generate coverage on 47a2180 wanted to post the following:

Coverage

7f3fc2 #131 47a218
Total Total +/- New
Rate 79.28% 79.67% +0.39% 100.00%
Hits 5662 5714 +52 540
Misses 1480 1458 -22 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@nnrustamo nnrustamo force-pushed the lbm_parallel branch 3 times, most recently from 22d782d to ab4e640 Compare January 25, 2026 06:49
@moosebuild
Copy link

Job Precheck, step Clang format on ab4e640 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/marlin/docs/PRs/131/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 7f3fc243b6dd0399c89a709b0020ed74dde7e586

- Remove commented-out clone line in LBMMicroscopicZeroGradientBC
- Add documentation for _boundary_rank bitmask encoding in LBMBoundaryCondition

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Comment on lines 9 to 10
min_parallel = 4
max_parallel = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nijat, min_parallel should be one. The important thing here is to show that a parallel run produces the same output as a serial output. If it doesn't that means there is a bug in the parallel implementation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have generated gold files with 1 rank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LBM parallelization

3 participants