Skip to content

#13:update docusaurus to v3 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#13:update docusaurus to v3 #14

wants to merge 2 commits into from

Conversation

@hieplq
Copy link
Contributor

@hieplq hieplq commented Mar 29, 2024

to build from old source after apply this pull request

  1. delete folders "node_modules" ".docusaurus"
  2. delete file package-lock.json
  3. run npm install && npm start

hieplq added 2 commits March 30, 2024 02:19
@hieplq
idempiere#13:update docusaurus to v3
85b80c8 
1. remove package-lock.json => reason package-lock.json is an automatically generated file that stores dependency information. This ensures a faster build process by eliminating the need to resolve dependencies every time you build your project

2. remove src/theme/SearchBar by https://github.com/praveenn77/docusaurus-lunr-search?tab=readme-ov-file#upgrading-from-docusaurus-v2-to-v3

3. update prismThemes by facebook/docusaurus#9316
@hieplq
idempiere#13:update docusaurus to v3
7d7ff9e 
fix for this one facebook/docusaurus#9998
@hieplq
Copy link
Contributor Author

hieplq commented Jun 22, 2024

action error can fix by this commit

hieplq@e70a054

@CarlosRuiz-globalqss
Copy link
Contributor

CarlosRuiz-globalqss commented Jun 17, 2025

Hi @hieplq

I think we don't have peer reviewers for this ticket.

Maybe just @anozimada could peer review it.

So, wondering if you want to be administrator of docusaurus, and we better give you direct permissions to commit instead of doing pull requests.

WDYT?

@hieplq
Copy link
Contributor Author

hieplq commented Jun 17, 2025

thank @CarlosRuiz-globalqss it's ok for me

@CarlosRuiz-globalqss
Copy link
Contributor

CarlosRuiz-globalqss commented Jun 17, 2025

thank @CarlosRuiz-globalqss it's ok for me

good @hieplq - I granted write permission to you - please let me know if you maybe need admin permissions in case you need to setup something additional for Actions or another configuration.

Talking about this pull request, I see it's updating to 3.2.0 - but that version doesn't appear at https://docusaurus.io/versions - maybe 3.2.1 was an update
Also docusaurus is actually in version 3.7.0, so better maybe to consider if is worthy to migrate to that latest one.

@d-ruiz reviewed and it seems there can be some incompatibilities, so it would be better to do it now that there are not much content to migrate.

@CarlosRuiz-globalqss
Copy link
Contributor

CarlosRuiz-globalqss commented Jun 17, 2025

Also docusaurus is actually in version 3.7.0

correction - current version is 3.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hieplq @CarlosRuiz-globalqss