Skip to content

feat: add success feedback for todo create/edit operations #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add success feedback for todo create/edit operations #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/modules/todos/components/todo-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
import { zodResolver } from "@hookform/resolvers/zod";
import { Upload, X } from "lucide-react";
import Image from "next/image";
import { useRouter } from "next/navigation";
import { useState, useTransition } from "react";
import { useForm } from "react-hook-form";
import toast from "react-hot-toast";
import type { z } from "zod";
import { Button } from "@/components/ui/button";
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
Expand Down Expand Up @@ -72,6 +74,7 @@ export function TodoForm({
categories: initialCategories,
initialData,
}: TodoFormProps) {
const router = useRouter();
const [isPending, startTransition] = useTransition();
const [imageFile, setImageFile] = useState<File | null>(null);
const [imagePreview, setImagePreview] = useState<string | null>(
Expand Down Expand Up @@ -162,12 +165,21 @@ export function TodoForm({
formData.append("image", imageFile);
}

if (initialData) {
await updateTodoAction(initialData.id, formData);
} else {
await createTodoAction(formData);
}
// Show success feedback before redirect
const actionPromise = initialData
? updateTodoAction(initialData.id, formData)
: createTodoAction(formData);

await toast.promise(actionPromise, {
loading: initialData ? "Updating todo..." : "Creating todo...",
success: initialData
? "Todo updated successfully!"
: "Todo created successfully!",
error: (err) =>
err instanceof Error ? err.message : "Failed to save todo",
});
} catch (error) {
// Error already shown by toast.promise
console.error("Error saving todo:", error);
}
});
Expand Down