Skip to content

Update TODO.md and ROADMAP.md for accuracy post-v2.4.0#160

Merged
igerber merged 2 commits intomainfrom
update-todos
Feb 16, 2026
Merged

Update TODO.md and ROADMAP.md for accuracy post-v2.4.0#160
igerber merged 2 commits intomainfrom
update-todos

Conversation

@igerber
Copy link
Copy Markdown
Owner

@igerber igerber commented Feb 16, 2026

Summary

Methodology references (required if estimator / math changes)

  • N/A - documentation-only changes, no estimator or math code modified

Validation

  • Tests added/updated: No test changes (documentation only)
  • Backtest / simulation / notebook evidence (if applicable): N/A

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

Fix stale line references, correct module line counts, mark completed
NaN handling as done, expand safe_inference migration table to 25 sites
across 11 files, add tech debt section from PR reviews, and bump
ROADMAP.md version from v2.3.0 to v2.4.0.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Overall Assessment: ⚠️ Needs changes

Executive Summary

  • Doc-only PR; no estimator/method/inference code changes.
  • Version bump and line-count updates match repo state.
  • Two documentation accuracy issues remain: a methodology-registry mismatch statement in TODO and the safe_inference() migration command/table inconsistency.

Methodology

  • P2 — Impact: TODO.md:L96 claims the Methodology Registry says TwoStageDiD/ImputationDiD bootstrap should support Mammen/Webb, but the registry sections for those methods state Rademacher-only multiplier bootstrap. This misstates methodology-source alignment and can misdirect follow-up work. — Fix: Update the TODO entry to reflect the actual registry text or cite the correct document that claims Mammen/Webb. References: docs/methodology/REGISTRY.md:L548-L613.

Code Quality

  • No findings (docs-only change).

Performance

  • No findings.

Maintainability

  • No findings.

Tech Debt

  • No findings beyond the documentation mismatch noted above.

Security

  • No findings.

Documentation/Tests

  • P2 — Impact: The “How to find them” command in TODO.md:L67-L70 doesn’t reproduce the table in TODO.md:L53-L65: it misses dict-based assignments like diff_diff/staggered.py:L777 and diff_diff/sun_abraham.py:L661, and it includes non-target lines such as diff_diff/utils.py:L178 (the safe_inference definition) and diff_diff/utils.py:L641 (inline inference not listed). This makes the migration list hard to verify. — Fix: Update the command to match ['t_stat'] assignments and document exclusions, or adjust the table to include diff_diff/utils.py:L641/clarify scope; consider using rg -n "t_stat\\s*=|\\['t_stat'\\]" diff_diff/*.py | rg -v "safe_inference" or similar.

Address two P2 findings: correct Rademacher/Mammen/Webb claim in tech
debt table (Registry only documents Rademacher), and improve safe_inference
grep command to catch dict-based patterns with documented limitations.
Add missing utils.py:641 call site to migration table.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@igerber
Copy link
Copy Markdown
Owner Author

igerber commented Feb 16, 2026

/ai-review

@github-actions
Copy link
Copy Markdown

🔁 AI review rerun (requested by @igerber)

Head SHA: 00c4616f45f6c588a1b18e9666f288b195efe26e


Overall Assessment: ✅ Looks good

Executive Summary

  • Docs-only updates in ROADMAP.md and TODO.md; no estimator/methodology code changes or registry edits.
  • Verified updated line counts and limitation references align with current file contents (e.g., estimators.py and large module counts).
  • One minor doc portability nit in the new grep command for locating inline inference sites.

Methodology

  • No findings. This PR only edits documentation and does not touch estimator logic, assumptions, or docs/methodology/REGISTRY.md.

Code Quality

  • No findings. Documentation-only changes.

Performance

  • No findings.

Maintainability

  • No findings.

Tech Debt

  • No findings. New section is informational only.

Security

  • No findings.

Documentation/Tests

  • Severity: P3
    Impact: The helper command uses \s with grep -E, which is GNU-specific and can fail on BSD/macOS, so contributors may miss inline inference sites.
    Concrete fix: Replace \s with [[:space:]] in the regex, or switch to grep -P and note the PCRE requirement.
    TODO.md:L68-L71

@igerber igerber merged commit ced4095 into main Feb 16, 2026
@igerber igerber deleted the update-todos branch February 16, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant