Merged
Conversation
- Add Priority Items section with linter/type errors and quick wins - Document 2 ruff errors (unused import, unsorted imports) - Document 10 mypy errors in staggered.py (Optional type handling) - Add bare exception handling locations with recommendations - Document code duplication across modules - Add API inconsistency notes for bootstrap parameters - Update module line counts and splitting recommendations - Add note about expected visualization test skips
Tier 1 - Blocking fixes: - Fix ruff linter errors (unused Union import, unsorted imports) - Fix 10 mypy type errors in staggered.py (Optional dict access guards) - Remove duplicate _get_significance_stars() from diagnostics.py Tier 2 - Quality improvements: - Replace bare `except Exception` with specific exceptions: - diagnostics.py: ValueError, KeyError, LinAlgError - honest_did.py: ValueError, TypeError - Document TwoWayFixedEffects cluster default behavior in docstring - Add bootstrap_weights parameter to CallawaySantAnna with deprecation warning for bootstrap_weight_type (will be removed in v2.0) Test updates: - Update test_staggered.py to test new bootstrap_weights parameter - Ensure backward compatibility with deprecated parameter All tests pass (456 passed, 21 skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes