Skip to content

Sort videos by views-per-day + download the top ones#146

Closed
deldesir wants to merge 2 commits intoiiab:masterfrom
deldesir:deldesir-patch-21
Closed

Sort videos by views-per-day + download the top ones#146
deldesir wants to merge 2 commits intoiiab:masterfrom
deldesir:deldesir-patch-21

Conversation

@deldesir
Copy link
Collaborator

@deldesir deldesir commented Mar 27, 2024

🚀 Pull Request Overview:

This PR adds views-per-day to the metadata so videos can be sorted automatically based on the playlist. If the playlist contains more than 100, a bookshelf with the top 100 videos (based on their views per day) is created. For playlists with less than 100 videos, the sorting still happens automatically.
Videos are sorted by views-per-day and limited by MAX_VIDEOS_PER_DOWNLOAD

📌 Testing scenarios:
See Issue #97

cc @EMG70

@deldesir deldesir marked this pull request as draft March 27, 2024 04:15
@holta holta added the enhancement New feature or request label Mar 27, 2024
@deldesir
Copy link
Collaborator Author

Test with a channel of 87 videos: https://www.youtube.com/@SpeechBlubs

image

Bookshelf is named after the channel

image

@deldesir deldesir requested a review from holta March 27, 2024 05:15
@deldesir deldesir self-assigned this Mar 27, 2024
@deldesir deldesir marked this pull request as ready for review March 27, 2024 05:16
@holta
Copy link
Member

holta commented Mar 27, 2024

Which test scenarios (top of #97 or bottom of #97) are most important for @EMG70 & others to confirm here?

@deldesir
Copy link
Collaborator Author

I will number them correctly for better communication

@deldesir
Copy link
Collaborator Author

deldesir commented Mar 27, 2024

Which test scenarios (top of #97 or bottom of #97) are most important for @EMG70 & others to confirm here?

Test scenario 12: Shelf Title Retrieval (Channel)

@deldesir
Copy link
Collaborator Author

deldesir commented Mar 27, 2024

Test scenario 6: Valid Download with Progress Observation (Playlist)
Playlist of 156 videos: https://www.youtube.com/playlist?list=PLjxrf2q8roU23XGwz3Km7sQZFTdB996iG

100 top videos downloaded:

image

Shelf named after the playlist title:

image

@EMG70
Copy link

EMG70 commented Mar 27, 2024

IIAB-DIAGNOSTICS - http://sprunge.us/oECy1e?en
This playlist https://www.youtube.com/playlist?list=PLGjplNEQ1it_oTvuLRNqXfz_v_0pq6unW of 14 videos was downloaded successfully and videos in order of ranking.. see screenshot.

Subsequent download attempts for these below have all failed in tasks but an empty bookshelf name is created.
https://www.youtube.com/playlist?list=PLGjplNEQ1it_oTvuLRNqXfz_v_0pq6unW 14 videos
https://www.youtube.com/playlist?list=PLfEr2kn3s-bo4LwlbyZugHPavhcdW8YMC 97 videos
Screenshot from 2024-03-27 14-51-32
Screenshot from 2024-03-27 14-52-05
Screenshot from 2024-03-27 14-55-11
Screenshot from 2024-03-27 15-03-21

@EMG70
Copy link

EMG70 commented Mar 27, 2024

There was a cancelled video download immediately after the successful download.I hope this did not cause problems for the database.I am currently creating a new VM and retest,will update shortly.
Screenshot from 2024-03-27 15-08-42

@EMG70
Copy link

EMG70 commented Mar 27, 2024

UPDATE
SUDO IIAB-DIAGNOSTICS - http://sprunge.us/XNJk13?en

A new VM was created .The first playlist downloaded OK with ranking showing well.It was observed that only the first playlist downloadS ok and populates videos in the shelf.All further downloads thereafter have been failing together with the previously successful playlist https://www.youtube.com/playlist?list=PLGjplNEQ1it_oTvuLRNqXfz_v_0pq6unW.
Screenshot from 2024-03-27 20-23-56
Screenshot from 2024-03-27 20-24-12
Screenshot from 2024-03-27 20-25-28
EMPTY SHELVES
Screenshot from 2024-03-27 20-25-44
Screenshot from 2024-03-27 20-30-39

@deldesir
Copy link
Collaborator Author

Thanks @EMG70, I'll fix this issue tonight. #150

@holta
Copy link
Member

holta commented Apr 15, 2024

@deldesir clarifies:

"[PR #146] has no diff because [PR #147] merged 4 days ago was built upon it."

"In fact, I resolved a merge conflict in it by adding its original commit, which was already present in [PR #147]."

@holta holta closed this Apr 15, 2024
@deldesir deldesir deleted the deldesir-patch-21 branch July 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants