Read error from xklb-metadata.db [leveraging yt-dlp STDERR]#175
Merged
holta merged 3 commits intoiiab:masterfrom Jun 10, 2024
Merged
Read error from xklb-metadata.db [leveraging yt-dlp STDERR]#175holta merged 3 commits intoiiab:masterfrom
holta merged 3 commits intoiiab:masterfrom
Conversation
This prevents metada fetching hanging on retry. Metadata fetching identifies requested videos by reading xklb-metadata for videos which path and webpath are identical and error column is null.
Collaborator
Author
|
Before applying this PR: After applying this PR: |
Collaborator
Author
|
Retrying to download the failed video still hangs the metadata fetching task despite applying a timestamp. I'll put this PR into draft mode while I figure out what's going on. |
Collaborator
Author
|
This PR is ready for merge. It will help in better understanding the underlying causes of failures. Another one will address the hanging at metadata fetch when a retry of a failed video is attempted. |
holta
changed the title
Member
@deldesir Clarify when you can? Thank you! |
Collaborator
Author
|
Yes, but it was affecting single videos. They were mostly unavailable videos, but any video which failed in a previous attempt would fit into this category as well. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reporting the exception as a status message, this PR reads the error from xklb db. This enhances debugging. Exception will still be logged because they're useful to understand errors from calibre-web's context. Reading the error from the database helps understand errors from xklb's context leveraging yt-dlp STDERR.
[ Building on: