Skip to content

Fixed the bug with the '!inline' tags, relates to #15 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oneyoung19 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed the bug with the '!inline' tags, relates to #15 #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0167bce
Fixed the bug with the '!inline' tags, relates to #15
oneyoung19 Sep 23, 2024
4db8e6f
Fixed the bug with the '!inline' tags, relates to #15
oneyoung19 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions inline-images.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,17 @@ function plugin(options = {}){

// Find !inline attribute
var not_inline_flag = $img.attr(NOT_INLINE_ATTR);

if(typeof not_inline_flag !== typeof undefined && not_inline_flag !== false){
// Remove the tag and don't process this file
return $img.removeAttr(NOT_INLINE_ATTR);
}

// Count async ops
count++;

getSrcBase64(options.basedir || file.dirname, getHTTP, src, function(err, result, res_format, skip_formatting){
if (err) {
if (err) {
console.error(err);
} else {
// Need a format in and a result for this to work
Expand All @@ -78,7 +78,8 @@ function plugin(options = {}){
});

// If no files are processing we don't need to wait as none were ever started
if (!img_tags.length){
// !img_tags.length no matched files, count <= 0 no processed files.
if (!img_tags.length || count <= 0){
file.contents = Buffer.from($.html());
callback(null, file);
}
Expand Down Expand Up @@ -133,7 +134,7 @@ function getSrcBase64(base, getHTTP, src, callback){
} else {
callback(null, src, null, true)
}
}
}
}

module.exports.plugin = plugin;
Expand Down