Expose oculus-hand profile by adding assets #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I believe we skipped this profile for a reason. The |
Contributor
Author
|
@cabanier I see, this may be the case when we added this profile, but now it does add new information - it has the gestures in the gamepad buttons array which the generic-hand doesn't have; so by skipping this, developers will never have access to the gesture button mapping. |
Member
|
Can you make it so that you grab the profiles from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assets for the
oculus-handprofile to enable CDN distribution and developer usage.The
oculus-handprofile has existed in the registry (packages/registry/profiles/oculus/oculus-hand.json) but was never exposed through the assets package. Without corresponding assets, the profile cannot be built into the distribution and remains unavailable on the CDN, making it effectively unusable by developers (it is not available from https://cdn.jsdelivr.net/npm/@webxr-input-profiles/assets@1.0.20/dist/profiles/profilesList.json).Changes
packages/assets/profiles/oculus-hand/profile.jsonconfigurationleft.glbandright.glbhand models (reused fromgeneric-hand)profilesList.jsonand distributed via CDNWhy reuse generic-hand models?
The
oculus-handprofile is designed for hand tracking (not physical controllers), and the existinggeneric-handmodels provide appropriate visual representation. The profile defines hand gesture inputs including:xr-standard-trigger)Impact
Developers working with Oculus/Meta hand tracking can now load and visualize the
oculus-handprofile through the standard WebXR input profiles library and CDN.