-
Notifications
You must be signed in to change notification settings - Fork 68
Docs: add general instructions for updating WebView #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/docs/getting-started/apps.md
Outdated
| ```shell | ||
| mount -o rw,remount /partition && cp /path/to/original/webview.apk /path/to/original/webview.apk.bak | ||
| ``` | ||
| - Override original WebView APK with the downloaded one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overwrite
docs/docs/getting-started/apps.md
Outdated
| ``` | ||
| - Copy new WebView to system | ||
| ```shell | ||
| mount -o rw,remount /partition && cp /sdcard/webview.apk /path/to/original/webview.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing this twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, missed that one. I did quite some restructuring iterations 😆 good catch 👍
| ### Frameo WebView Update | ||
| Follow instructions below to update WebView to 106. This has been tested and working on Android 6.01 10.1" Frameo devices: | ||
| ### Frameo WebView Update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this header indicate Android 7+ or something?
docs/docs/getting-started/apps.md
Outdated
| The basic procedure of updating the WebView installation consists of a few steps. Read through and understand them first, before you attempt any changes. | ||
| To make it easier to follow, there are tested and working examples for Android 6.01 10.1" Frameo devices provided at the end. If you have one of those, you might as well skip directly to them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is kind of confusing. Do you mean the older instruction for Android 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my idea was to have this section for general instructions how to do it on any device/android version and still leave the old - but tested and working - instructions as a subsection at the end.
There is quite some "path/to/x/apk" in the general instructions and the whole mounting the correct partition thing, so it might be a little confusing for some. That's why I thought it might be helpful to have those "older" but very specific instructions with actual paths as a reference.
But I can see how it's confusing if we say "read and understand those first" and then "you might skip directly to the commands" 😆 So I'd propose I just rewrite that part, but I'd still want to mention the instructions for those specific devices.
Would that work for you or do you have any more suggestions how to make this clearer?
|
Thx for contributing! Just a couple changes requested. |
|
Thanks for your feedback. I fixed some of your catches, but I need some more feedback on that confusing part. I'll provide a new proposal after that, that incorporates your feedback. |
|
I'd also want to add a disclaimer, that this might not work for every device, as there might be some vendor lockdowns in place. Also people should be aware, that they might be losing warranty with this procedure, even though I'm not sure about that, and should be ready to restore their WebView from backup or reset their device in case of failure. In the end, this should work for all possible kinds of devices, but as there are a myriad of different android versions and devices out there, people should just be aware that it might not be smooth sailing or not even work at all. Would you approve such a disclaimer? |
Sure. Just try to keep everything as brief as possible. |
|
I added the disclaimer and changed some bits to (hopefully) make things clearer. |
|
Anything else I can/should do, to bring this to an approved state? |
|
I like the disclaimer and warning, and think we should add the "Find the current WebView APK on your device" step (and to replace that path in the other commands), but I feel like the rest is too wordy and repeated without adding much. What are your thoughts on just doing those minimal updates? |
|
Sure, I can do that. Sounds good to me, it is quite repetitive right now. |
Here is a little documentation how to update WebView on devices other than Android 6.01 10.1" Frameo, as you asked for in #406