Update versions and add instructions on publishing to local maven repo #603
Conversation
davidwheeler123
left a comment
davidwheeler123
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I've added one comment about upgrading to Kotlin 2 - is that something that's important to you?
I'll leave @kdubb to approve
buildSrc/src/main/kotlin/Versions.kt
Outdated
| */ | ||
| val javaTarget = JavaVersion.VERSION_1_8 | ||
| const val kotlin = "1.9.10" | ||
| const val kotlin = "2.0.0" |
There was a problem hiding this comment.
Kotlin 2.0.0 is very new, sometimes it's good to wait a few minor/patch versions before upgrading. But if we do want to upgrade, it looks like we should also update to a more recent Gradle (8.3+) as well
There was a problem hiding this comment.
Oops looks like I was looking at an old branch, we're already using gradle 8.4 🤦
There was a problem hiding this comment.
Yeah, unless there's a reason to move to 2.0. Probably stay on 1.9.x.
Upgrading to 1.9.20 seems fine.
There was a problem hiding this comment.
No not important at all. I just always try to stay latest on everything while avoiding bleeding edge. I don't even use Kotlin actually, I've been meaning to start switching at least some of my java work to it but haven't gone there yet. So 1.9 is fine with me. :)
3 participants
I was being held up from updating my website by the old version so I compiled it myself. This bumps some of the dependency versions and explains how to publish locally.