Use CQL builder #387
Merged
Use CQL builder #387
+82
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors CQL query construction to use the cqlbuilder package instead of string concatenation. The change separates owner restriction logic from the side parameter, enabling more flexible query building while maintaining access control. This represents a shift toward more maintainable and type-safe query construction.
Changes:
- Replaced string concatenation with CQL builder for query construction
- Separated owner restriction logic from side parameter handling
- Added support for
cql.allRecordsfield handling in the CQL parser
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| broker/patron_request/db/prcql.go | Adds FieldAllRecords struct to handle cql.allRecords queries |
| broker/patron_request/api/api-handler.go | Refactors query building to use cqlbuilder and separates owner/side restrictions |
| broker/oapi/open-api.yaml | Removes trailing newline |
| broker/go.mod | Updates cql-go dependency to newer version |
JanisSaldabols
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses CQL builder instead of string concat for creating CQL.
This PR applies owner restriction separately from the
sideparam so it's possible to makesideoptional. TBD if this is something we want.