RPM: Fixes for systemd service file; reorder spec #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store systemd service in /usr/lib/systemd/system. Use systemd-rpm-macros for dealing with systemd service in post, preun, postun. Proper log file /var/log/pazpar2.log
There was a problem hiding this comment.
Pull request overview
This PR updates the pazpar2 RPM package to follow systemd best practices by storing the service file in /usr/lib/systemd/system (instead of /etc/systemd/system), adopting systemd-rpm-macros for service lifecycle management, and updating the log file path to a proper file location.
Changes:
- Moved systemd service file from
/etc/systemd/systemto/usr/lib/systemd/systemwith proper permissions (0644) - Replaced manual systemctl calls with systemd macros (
%systemd_post,%systemd_preun,%systemd_postun_with_restart) - Updated log path from directory
/var/log/pazpar2to file/var/log/pazpar2.logand PID file from/var/run/pazpar2.pidto/run/pazpar2.pid
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rpm/pazpar2.sysconfig | Updates log file path to specific file, modernizes PID file location, and reorders command options |
| rpm/pazpar2.service | Removes PIDFile directive (not needed with Type=simple) |
| pazpar2.spec | Adds systemd-rpm-macros dependency, updates service file location and permissions, replaces manual systemctl commands with systemd macros, and reorders package definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store systemd service in /usr/lib/systemd/system.
Use systemd-rpm-macros for dealing with systemd service in post, preun, postun.
Proper log file /var/log/pazpar2.log