RSRVR-27 empty match key removes record from cluster #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the given match key config of course.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements RSRVR-27, which adds support for removing records from clusters when their match key becomes empty. Previously, records with empty match keys would remain in clusters; now they are properly removed.
Changes:
- Added logic to detect and handle empty match keys by removing affected records from clusters
- Added new test
testClustersNoKeyto verify the new behavior across three phases - Updated existing test expectations to reflect that records with empty match keys are no longer included in cluster results
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| server/src/main/java/com/indexdata/reservoir/server/Storage.java | Refactored empty key handling from updateClusterValues to updateClusterForRecord, added new removeClusterRecord method to remove records with empty keys from clusters |
| server/src/test/java/com/indexdata/reservoir/server/MainVerticleTest.java | Added comprehensive test for empty key removal behavior and updated expectations in existing tests to reflect that empty-key records are no longer clustered |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server/src/test/java/com/indexdata/reservoir/server/MainVerticleTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/indexdata/reservoir/server/Storage.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server/src/test/java/com/indexdata/reservoir/server/MainVerticleTest.java
Outdated
Show resolved
Hide resolved
…leTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jakub-id
approved these changes
Feb 3, 2026
adamdickmeiss
deleted the
RSRVR-27-empty-match-key-list-removes-record-from-cluster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the given match key config of course.
https://index-data.atlassian.net/browse/RSRVR-27