Fix for tooltip flickering issue, tooltip will now also hide on mouse click when keepAlive is set to true#1
Open
breity wants to merge 13 commits intoindyone:masterfrom
Open
Fix for tooltip flickering issue, tooltip will now also hide on mouse click when keepAlive is set to true#1breity wants to merge 13 commits intoindyone:masterfrom
breity wants to merge 13 commits intoindyone:masterfrom
Conversation
…lick when keepAlive option is set to true
Prevent quick hover - adds a delay for activating tooltips on hover events (defaults to 500ms)
…correctly in certain cases; Added offset (4px) from window edge when tooltip is positioned at edge of viewport
…ctionality previously added to keepAlive
… tooltip. Plays nice with hideOnClick
Adding features from alanhussey: hideOnClick and delayHid options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks so much for these enhancements! They are really useful.
I added a couple things:
I implemented a fix for the flickering that can occur when hovering over the edge of a TipTip tooltip and its trigger element.
I also made tooltips hide when the user clicks anywhere on the page except for on the tooltip element itself when the keepAlive option is set to true. This is in addition to the default behavior of the tooltip hiding when the user's mouse leaves the tooltip element. I added this because it is common practice in other tooltip plugins (e.g. miniTip, which inspired this addition) and users might expect the same behavior from TipTip. It also seems a bit more intuitive to me, especially when the activation is set to 'click' or 'focus'.
Perhaps you want to include these in your fork?