Fix IDE warnings #3186
Open
Fix IDE warnings #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zpf121 <1219290549@qq.com>
### What problem does this PR solve? Environment: ``` Ubuntu 25.10 Clang-20/21 Gcc-15.2 ``` The `simde` package will introduce error ` definition with same mangled name ` because of the macro `SIMDE_FUNCTION_ATTRIBUTES` is defined as `static`, which will lead to multiple definitions under c++ 23 modules. Issue link:infiniflow#3166 ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) --------- Co-authored-by: Ubuntu <ubuntu@ragflow-arm2.asia-northeast1-b.c.ragflow-462809.internal>
### What problem does this PR solve? 1. Remove all the code related to **BufferObj/BufferManager** and refactor all FileWorker implementations. - For FileWorker instances that contain a `char *` payload, we now manage their loading state directly with **mmap** instead of using a state machine + LRU. - For other FileWorker types (curruntly only **HnswFIleWorker**), we manage their loading state solely with an LRU cache. 2. Becauce the state-machine-based loading management has been eliminated, we use the `tmp` and `data` directories to handle the part of state. - All data generated after previous checkpoint is mmapped into `tmp`. - During a checkpoint we call `msync`, the copy the data from `tmp` to `data`. - This results in higher disk usage while the database is running, and the copy operation creates a large amount of disk I/O, which can cause background cleaning to fail (e.g., RocksDB read/write timeouts). To mitigate the second issue, more frequent checkpoints may be required. 3. For **VersionFileWorker**, the payload is not a `char *`, but we still manage it purely with `mmap`. This leads to sub-optimal performance on certain code paths; the issue will be addressed in a future fix. 4. Comment out all code related `snapshot` and wait for adaptation. 5. There are some bugs in the `show` command. ### Type of change - [x] New Feature (non-breaking change which adds functionality) - [x] Breaking Change (fix or feature that could cause existing functionality not to work as expected) - [x] Refactoring - [x] Performance Improvement - [x] Test cases --------- Signed-off-by: noob <yixiao121314@outlook.com> Co-authored-by: qinling0210 <88864212+qinling0210@users.noreply.github.com>
### What problem does this PR solve? As title ### Type of change - [x] Refactoring --------- Signed-off-by: Jin Hai <haijin.chn@gmail.com>
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3186 +/- ##
==========================================
- Coverage 47.04% 39.93% -7.11%
==========================================
Files 722 722
Lines 150043 150043
Branches 27247 27247
==========================================
- Hits 70591 59925 -10666
- Misses 69835 81108 +11273
+ Partials 9617 9010 -607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As title.
Type of change