-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Feat: SandBox docker CLI error in ARM CPU #12433 #12434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated Dockerfile to support multiple architectures for Docker Sandbox installation.
sandbox/executor_manager/Dockerfile
Outdated
| *) echo "Unsupported architecture: ${TARGETARCH}${TARGETVARIANT}" && exit 1 ;; \ | ||
| esac; \ | ||
| echo "Downloading Docker for architecture: ${DOCKER_ARCH}"; \ | ||
| curl -fsSL "https://download.docker.com/linux/static/stable/${DOCKER_ARCH}/docker-27.0.3.tgz" | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @lizhizhou
Thank you for your contribution. I think it's better to keep the version (29.1.0) for avoiding unexpected issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept
sandbox/executor_manager/Dockerfile
Outdated
| tar -xzf docker.tgz && \ | ||
| mv docker/docker /usr/bin/docker && \ | ||
| rm -rf docker docker.tgz | ||
| # 根据架构下载对应的 Docker CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate it if you removed these Chinese runes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept.
What problem does this PR solve?
Add multi-architecture support for Sandbox
Updated Dockerfile to support multiple architectures for Docker Sandbox installation.
Type of change