Skip to content

Conversation

@lizhizhou
Copy link

@lizhizhou lizhizhou commented Jan 5, 2026

What problem does this PR solve?

Add multi-architecture support for Sandbox

Updated Dockerfile to support multiple architectures for Docker Sandbox installation.

Type of change

  • New Feature (non-breaking change which adds functionality)

Updated Dockerfile to support multiple architectures for Docker Sandbox installation.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 5, 2026
@KevinHuSh KevinHuSh requested a review from yongtenglei January 5, 2026 06:10
@KevinHuSh KevinHuSh changed the title [Bug]: SandBox docker CLI error in ARM CPU #12433 [Feat]: SandBox docker CLI error in ARM CPU #12433 Jan 5, 2026
@KevinHuSh KevinHuSh changed the title [Feat]: SandBox docker CLI error in ARM CPU #12433 Feat: SandBox docker CLI error in ARM CPU #12433 Jan 5, 2026
*) echo "Unsupported architecture: ${TARGETARCH}${TARGETVARIANT}" && exit 1 ;; \
esac; \
echo "Downloading Docker for architecture: ${DOCKER_ARCH}"; \
curl -fsSL "https://download.docker.com/linux/static/stable/${DOCKER_ARCH}/docker-27.0.3.tgz" | \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @lizhizhou

Thank you for your contribution. I think it's better to keep the version (29.1.0) for avoiding unexpected issues.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept

tar -xzf docker.tgz && \
mv docker/docker /usr/bin/docker && \
rm -rf docker docker.tgz
# 根据架构下载对应的 Docker CLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate it if you removed these Chinese runes here.

Copy link
Author

@lizhizhou lizhizhou Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants